Re: [PATCH v3] pstore: Don't use semaphores in always-atomic-context code

From: Kees Cook
Date: Tue Mar 15 2022 - 14:12:06 EST


On Mon, 14 Mar 2022 19:59:53 +0100, Jann Horn wrote:
> pstore_dump() is *always* invoked in atomic context (nowadays in an RCU
> read-side critical section, before that under a spinlock).
> It doesn't make sense to try to use semaphores here.
>
> This is mostly a revert of commit ea84b580b955 ("pstore: Convert buf_lock
> to semaphore"), except that two parts aren't restored back exactly as they
> were:
>
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore: Don't use semaphores in always-atomic-context code
https://git.kernel.org/kees/c/8126b1c73108

--
Kees Cook