Re: [PATCH v4] staging: greybus: introduce pwm_ops::apply

[Song Chen]

在 2022/3/14 23:03, Greg KH 写道:
> On Wed, Mar 09, 2022 at 09:59:34AM +0800, Song Chen wrote:
> > Introduce newer .apply function in pwm_ops to
> > replace legacy operations,like enable, disable,
> > config and set_polarity.
>
> You can use the full 72 columns please.

will do.

> > This guarantees atomic changes of the pwm
> > controller configuration and also reduces the
> > size of the driver.
>
> The driver is bigger (more lines) with this change, so why do you say it
> is smaller?

ohh, yes, you are right. I copied from another commit with similar 
function and didn't count lines carefully.

i will amend the commit message and submit a new one, many thanks.

> thanks,
>
> greg k-h

BR

Song