Re: [PATCH v2 6/6] staging: r8188eu: remove local BIT macro

[Dan Carpenter]

On Wed, Mar 16, 2022 at 12:01:28PM +0300, Dan Carpenter wrote:
> On Tue, Mar 15, 2022 at 09:50:41PM +0100, Martin Kaiser wrote:
> > The r8188eu driver defines a local BIT(x) macro. Remove this local macro
> > and use the one from include/linux/bits.h.
> > 
> > The global BIT macro returns an unsigned long value. Therefore, we have to
> > cast DYNAMIC_BB_DYNAMIC_TXPWR to u32 explicitly. This define is used with
> > the bitwise not operator.
> 
> It doesn't change run time at all if you leave it as unsigned long.
> I don't know if there are static checkers which care, but if there are
> then those checkers are wrong.  It's nicer to not have the unnecesary
> cast.

Oop.  It's a GCC warning...

People accept such absolute garbage from GCC.  It's like in Africa when
you get bitten by a snake they rub cow dung into the wound.  If it hurts
it must be good.

regards,
dan carpenter