Re: [Linux-cachefs] [PATCH v5 17/22] erofs: implement fscache-based data read for non-inline layout

[Gao Xiang]

On Wed, Mar 16, 2022 at 09:17:18PM +0800, Jeffle Xu wrote:
> This patch implements the data plane of reading data from bootstrap blob
> file over fscache for non-inline layout.
> 
> Be noted that compressed layout is not supported yet.
> 
> Signed-off-by: Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx>
> ---
>  fs/erofs/fscache.c  | 94 +++++++++++++++++++++++++++++++++++++++++++++
>  fs/erofs/inode.c    |  6 ++-
>  fs/erofs/internal.h |  1 +
>  3 files changed, 100 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c
> index 654414aa87ad..df56562f33c4 100644
> --- a/fs/erofs/fscache.c
> +++ b/fs/erofs/fscache.c
> @@ -4,6 +4,12 @@
>   */
>  #include "internal.h"
>  
> +struct erofs_fscache_map {
> +	struct erofs_fscache_context *m_ctx;
> +	erofs_off_t m_pa, m_la, o_la;
> +	u64 m_llen;

Can we directly use "struct erofs_map_blocks map"?
So "erofs_fscache_get_map" can be avoided then.

Thanks,
Gao Xiang