Re: [PATCH AUTOSEL 5.10 19/20] bnx2: Fix an error message

From: Pavel Machek
Date: Thu Mar 17 2022 - 07:23:25 EST


Hi!

> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
>
> [ Upstream commit 8ccffe9ac3239e549beaa0a9d5e1a1eac94e866c ]
>
> Fix an error message and report the correct failing function.

This patch is not really fixing an important bug, it is just tweaking
an error message. I'm not sure why it is being queued for stable. I
believe AUTOSEL process should be more careful.

Second, at least for 5.10 and older, it is not _fixing_ bug, it is
_adding_ one, as old message is correct there.

Please drop.
Pavel

> +++ b/drivers/net/ethernet/broadcom/bnx2.c
> @@ -8229,7 +8229,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev)
> rc = pci_set_consistent_dma_mask(pdev, persist_dma_mask);
> if (rc) {
> dev_err(&pdev->dev,
> - "pci_set_consistent_dma_mask failed, aborting\n");
> + "dma_set_coherent_mask failed, aborting\n");
> goto err_out_unmap;
> }
> } else if ((rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) != 0) {

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature