Re: [PATCH] ASoC: SOF: topology: Use kmemdup() to replace kzalloc + memcpy
From: Pierre-Louis Bossart
Date: Thu Mar 17 2022 - 10:19:51 EST
On 3/17/22 04:38, Yihao Han wrote:
fix memdup.cocci warning:
sound/soc/sof/topology.c:876:19-26: WARNING opportunity for kmemdup
Generated by: scripts/coccinelle/api/memdup.cocci
Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
Thanks for the patch
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
---
sound/soc/sof/topology.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index 367fbe2d5b31..369693cc6d10 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -873,11 +873,10 @@ static int sof_control_load_bytes(struct snd_soc_component *scomp,
/* copy the private data */
if (priv_size > 0) {
- scontrol->priv = kzalloc(priv_size, GFP_KERNEL);
+ scontrol->priv = kmemdup(control->priv.data, priv_size, GFP_KERNEL);
if (!scontrol->priv)
return -ENOMEM;
- memcpy(scontrol->priv, control->priv.data, priv_size);
scontrol->priv_size = priv_size;
}