Re: [RFC PATCH v2 1/4] [PATCH 1/4] mm: refactor of vma_merge()

From: Vlastimil Babka
Date: Thu Mar 17 2022 - 14:53:36 EST


On 3/11/22 18:45, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter, more understandable and
> suitable for tracing of successful merges that are made possible by
> following patches in the series. Main change is the elimination of code
> duplicity in the case of merge next check. This is done by first doing
> checks and caching the results before executing the merge itself. Exit
> paths are also unified.
>
> Signed-off-by: Jakub Matěna <matenajakub@xxxxxxxxx>

Reviewed-by: Vlastimil Babka <vbabka@xxxxxxx>

It's a nice cleanup on its own. Removed duplication and reduced indentation
levels helps.