RE: [PATCH 05/18] dt-bindings: irqchip: fsl: include generic schema

From: Joakim Zhang
Date: Thu Mar 17 2022 - 21:23:15 EST



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Sent: 2022年3月17日 19:57
> To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Marc Zyngier <maz@xxxxxxxxxx>;
> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Andreas Färber <afaerber@xxxxxxx>; Manivannan
> Sadhasivam <mani@xxxxxxxxxx>; Linus Walleij <linusw@xxxxxxxxxx>; Imre
> Kaloz <kaloz@xxxxxxxxxxx>; Krzysztof Halasa <khalasa@xxxxxxx>; Michael
> Walle <michael@xxxxxxxx>; Mark-PK Tsai <mark-pk.tsai@xxxxxxxxxxxx>;
> Daniel Palmer <daniel@xxxxxxxxx>; Jonathan Neuschäfer
> <j.neuschaefer@xxxxxxx>; Palmer Dabbelt <palmer@xxxxxxxxxxx>; Paul
> Walmsley <paul.walmsley@xxxxxxxxxx>; Nishanth Menon <nm@xxxxxx>;
> Tero Kristo <kristo@xxxxxxxxxx>; Santosh Shilimkar <ssantosh@xxxxxxxxxx>;
> Neil Armstrong <narmstrong@xxxxxxxxxxxx>; Dinh Nguyen
> <dinguyen@xxxxxxxxxx>; Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx>;
> Joakim Zhang <qiangqing.zhang@xxxxxxx>; Lucas Stach
> <l.stach@xxxxxxxxxxxxxx>; Paul Cercueil <paul@xxxxxxxxxxxxxxx>; Jiaxun
> Yang <jiaxun.yang@xxxxxxxxxxx>; Claudiu Beznea
> <claudiu.beznea@xxxxxxxxxxxxx>; Jason Cooper <jason@xxxxxxxxxxxxxx>;
> Paul Burton <paulburton@xxxxxxxxxx>; Thomas Bogendoerfer
> <tsbogend@xxxxxxxxxxxxxxxx>; Birger Koblitz <mail@xxxxxxxxxxxxxxxxx>; Bert
> Vermeulen <bert@xxxxxxxx>; John Crispin <john@xxxxxxxxxxx>; Geert
> Uytterhoeven <geert+renesas@xxxxxxxxx>; Sagar Kadam
> <sagar.kadam@xxxxxxxxxx>; Suman Anna <s-anna@xxxxxx>; Lokesh Vutla
> <lokeshvutla@xxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-actions@xxxxxxxxxxxxxxxxxxx; openbmc@xxxxxxxxxxxxxxxx;
> linux-riscv@xxxxxxxxxxxxxxxxxxx; linux-oxnas@xxxxxxxxx
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Subject: [PATCH 05/18] dt-bindings: irqchip: fsl: include generic schema
>
> Include generic interrupt-controller.yaml schema, which enforces node
> naming and other generic properties.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---

Reviewed-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>

Best Regards,
Joakim Zhang
> .../devicetree/bindings/interrupt-controller/fsl,intmux.yaml | 5 ++++-
> .../bindings/interrupt-controller/fsl,irqsteer.yaml | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> index 1d6e0f64a807..5ead6b7dcb42 100644
> ---
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.
> +++ yaml
> @@ -9,6 +9,9 @@ title: Freescale INTMUX interrupt multiplexer
> maintainers:
> - Joakim Zhang <qiangqing.zhang@xxxxxxx>
>
> +allOf:
> + - $ref: /schemas/interrupt-controller.yaml#
> +
> properties:
> compatible:
> const: fsl,imx-intmux
> @@ -45,7 +48,7 @@ required:
> - clocks
> - clock-names
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> index bcb5e20fa9ca..4b5080f754ea 100644
> ---
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqstee
> +++ r.yaml
> @@ -9,6 +9,9 @@ title: Freescale IRQSTEER Interrupt Multiplexer
> maintainers:
> - Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>
> +allOf:
> + - $ref: /schemas/interrupt-controller.yaml#
> +
> properties:
> compatible:
> oneOf:
> @@ -70,7 +73,7 @@ required:
> - fsl,channel
> - fsl,num-irqs
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.32.0