Re: [PATCH V5 1/3] spi: mediatek: add spi memory support for ipm design

[AngeloGioacchino Del Regno]

Il 18/03/22 03:50, Leilk Liu ha scritto:
> this patch add the support of spi-mem for ipm design.
>
> Signed-off-by: Leilk Liu <leilk.liu@xxxxxxxxxxxx>
> ---
>   drivers/spi/spi-mt65xx.c | 302 ++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 301 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c
> index 1a0b3208dfca..ea6223259060 100644
> --- a/drivers/spi/spi-mt65xx.c
> +++ b/drivers/spi/spi-mt65xx.c

...snip...

> @@ -78,8 +79,21 @@
>   #define SPI_CMD_IPM_GET_TICKDLY_OFFSET    22
>   
>   #define SPI_CMD_IPM_GET_TICKDLY_MASK	GENMASK(24, 22)
> +
> +#define PIN_MODE_CFG(x)	((x) / 2)
> +
> +#define SPI_CFG3_IPM_PIN_MODE_OFFSET		0

This definition is useless, the offset is zero... and this is used
to bitshift zero.


Please remove that, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>