Re: [PATCH v2 1/5] platform/chrome: cros_kbd_led_backlight: sort headers alphabetically

From: Guenter Roeck
Date: Fri Mar 18 2022 - 13:11:20 EST


On Mon, Mar 14, 2022 at 05:08:31PM +0800, Tzung-Bi Shih wrote:

Nit: There should be some text here describing the rationale.

With that added,

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> Signed-off-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
> ---
> Changes from v1:
> - Update email address accordingly.
>
> drivers/platform/chrome/cros_kbd_led_backlight.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_kbd_led_backlight.c b/drivers/platform/chrome/cros_kbd_led_backlight.c
> index aa409f0201fb..f9587a562bb7 100644
> --- a/drivers/platform/chrome/cros_kbd_led_backlight.c
> +++ b/drivers/platform/chrome/cros_kbd_led_backlight.c
> @@ -4,12 +4,12 @@
> // Copyright (C) 2012 Google, Inc.
>
> #include <linux/acpi.h>
> -#include <linux/leds.h>
> #include <linux/delay.h>
> #include <linux/err.h>
> -#include <linux/module.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> +#include <linux/leds.h>
> +#include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
>