Re: [PATCH] hwmon: (dell-smm) Add Inspiron 3505 to fan type blacklist

From: Guenter Roeck
Date: Fri Mar 18 2022 - 18:12:42 EST


On Fri, Mar 18, 2022 at 07:34:08PM +0100, Armin Wolf wrote:
> Sadly, while firmware 1.5 fixed temperature labels on my
> Inspiron 3505, it also caused fan type calls to take
> ca. 4 seconds with the fan being at full speed.
> Fix the resulting delays by adding the model to the
> blacklist.
>
> Tested on a Dell Inspiron 3505.
>
> Signed-off-by: Armin Wolf <W_Armin@xxxxxx>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index a14e810f5598..c34342253d6e 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1165,6 +1165,13 @@ static const struct dmi_system_id i8k_blacklist_fan_type_dmi_table[] __initconst
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 580 "),
> },
> },
> + {
> + .ident = "Dell Inspiron 3505",
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Inspiron 3505"),
> + },
> + },
> { }
> };