Re: [PATCH v2] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration

From: Sinan Kaya
Date: Sat Mar 19 2022 - 15:55:51 EST


On 3/19/2022 2:24 AM, Christophe JAILLET wrote:
Le 22/01/2022 à 19:05, Sinan Kaya a écrit :
On 1/15/2022 2:35 AM, Christophe JAILLET wrote:
As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

Simplify code and remove some dead code accordingly.

[1]: https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@xxxxxxxxxxxxx/#t


Can we please document this?

Hi, the patch has been applied, but [1] is sometimes given as an explanation link.

CJ


[1]: https://lists.linuxfoundation.org/pipermail/iommu/2019-February/033674.html

Sounds good, please carry my

Acked-By: Sinan Kaya <okaya@xxxxxxxxxx>