Re: [v5 3/4] ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset

From: Tzung-Bi Shih
Date: Sun Mar 20 2022 - 23:59:50 EST


On Sat, Mar 19, 2022 at 07:41:10PM +0800, Jiaxin Yu wrote:
> @@ -1145,6 +1140,13 @@ static int mt8192_mt6359_dev_probe(struct platform_device *pdev)
> goto err_speaker_codec;
> }
>
> + headset_codec = of_get_child_by_name(pdev->dev.of_node, "mediatek,headset-codec");
> + if (!headset_codec) {
> + ret = -EINVAL;
> + dev_err_probe(&pdev->dev, ret, "Property 'headset_codec' missing or invalid\n");
> + goto err_headset_codec;
> + }

(to be neat) Does it have any reason to prevent from using of_parse_phandle()
but of_get_child_by_name()?