Re: [PATCH V2] tty: synclink_cs: Use bitwise instead of arithmetic operator for flags

[Jiri Slaby]

On 21. 03. 22, 8:12, Haowen Bai wrote:
> This silences the following coccinelle warning:
> drivers/s390/char/tape_34xx.c:360:38-39: WARNING: sum of probable bitmasks, consider |
>
> we will try to make code cleaner
>
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> ---
> V1 -> V2: fix title subject misspelling try -> tty.
>
>   drivers/char/pcmcia/synclink_cs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 78baba5..e6f2186 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -922,7 +922,7 @@ static void rx_ready_async(MGSLPC_INFO *info, int tcd)
>   		// BIT7:parity error
>   		// BIT6:framing error
>   
> -		if (status & (BIT7 + BIT6)) {
> +		if (status & (BIT7 | BIT6)) {
>   			if (status & BIT7)
>   				icount->parity++;
>   			else


--
js