Re: [PATCH v1 4/5] iio: accel: bma400: Add separate channel for step counter
From: Andy Shevchenko
Date: Mon Mar 21 2022 - 04:43:36 EST
On Sat, Mar 19, 2022 at 8:10 PM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote:
>
> Added channel for step counter which can be enable or disable
> through the sysfs interface.
...
> + u32 steps_raw;
I would expect this to be u8 ...[3].
...
> + ret = regmap_bulk_read(data->regmap, BMA400_STEP_CNT0_REG,
> + &steps_raw, 3 * sizeof(u8));
sizeof(&steps_raw);
...
> + *val = steps_raw & 0x00FFFFFF;
And here it seems to be be24_to_cpu() like Jonathan mentioned,
--
With Best Regards,
Andy Shevchenko