Re: [PATCH] staging: greybus: codecs: fix type confusion with dedicated list iterator variable

From: Dan Carpenter
Date: Mon Mar 21 2022 - 04:49:31 EST


The subject says that it fixes a bug but it does not.

On Sat, Mar 19, 2022 at 09:20:58PM +0100, Jakob Koschel wrote:
> If the list does not exit early then data == NULL and 'module' does not
> point to a valid list element.
> Using 'module' in such a case is not valid and was therefore removed.

This paragraph is confusing jumble words. Just say: "This code is fine".

>
> In preparation to limit the scope of the list iterator to the list
> traversal loop, use a dedicated pointer pointing to the found element [1].

This paragraph is the information we need. Just add something like
"This patch has no effect on runtime".

regards,
dan carpenter