Re: [PATCH] zorro: Fix a resource leak in zorro7xx_remove_one()

[Geert Uytterhoeven]

Hi Christophe,

On Sat, Mar 19, 2022 at 8:01 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
> The error handling path of the probe releases a resource that is not freed
> in the remove function.
>
> In some cases, a ioremap() must be undone.
>
> Add the missing iounmap() call in the remove function.
>
> Fixes: 45804fbb00ee ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks for your patch!

The online-summary should be
"scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one()".

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds