[RFC PATCH 09/10] mmc: core: improve API to make clear sw_reset from bus_ops is for cards

From: Wolfram Sang
Date: Mon Mar 21 2022 - 07:52:20 EST


To make it unambiguous that bus_ops->sw_reset() is for cards and not for
controllers, we a) add 'card' to the function name and b) make the
function argument mmc_card instead of mmc_host. All users are converted,
too.

Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
---
drivers/mmc/core/core.c | 4 ++--
drivers/mmc/core/core.h | 2 +-
drivers/mmc/core/sdio.c | 6 ++++--
3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index 1d874b064202..7e48570007f9 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2023,10 +2023,10 @@ int mmc_card_sw_reset(struct mmc_card *card)
struct mmc_host *host = card->host;
int ret;

- if (!host->bus_ops->sw_reset)
+ if (!host->bus_ops->card_sw_reset)
return -EOPNOTSUPP;

- ret = host->bus_ops->sw_reset(host);
+ ret = host->bus_ops->card_sw_reset(card);
if (ret)
pr_warn("%s: tried to SW reset card, got error %d\n",
mmc_hostname(host), ret);
diff --git a/drivers/mmc/core/core.h b/drivers/mmc/core/core.h
index c54270a6d457..27e8435ae779 100644
--- a/drivers/mmc/core/core.h
+++ b/drivers/mmc/core/core.h
@@ -28,7 +28,7 @@ struct mmc_bus_ops {
int (*alive)(struct mmc_host *);
int (*shutdown)(struct mmc_host *);
int (*card_hw_reset)(struct mmc_card *);
- int (*sw_reset)(struct mmc_host *);
+ int (*card_sw_reset)(struct mmc_card *);
bool (*cache_enabled)(struct mmc_host *);
int (*flush_cache)(struct mmc_host *);
};
diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 30242faf703e..e6460285b46b 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -1154,8 +1154,10 @@ static int mmc_sdio_card_hw_reset(struct mmc_card *card)
return mmc_sdio_reinit_card(host);
}

-static int mmc_sdio_sw_reset(struct mmc_host *host)
+static int mmc_sdio_card_sw_reset(struct mmc_card *card)
{
+ struct mmc_host *host = card->host;
+
mmc_set_clock(host, host->f_init);
sdio_reset(host);
mmc_go_idle(host);
@@ -1176,7 +1178,7 @@ static const struct mmc_bus_ops mmc_sdio_ops = {
.runtime_resume = mmc_sdio_runtime_resume,
.alive = mmc_sdio_alive,
.card_hw_reset = mmc_sdio_card_hw_reset,
- .sw_reset = mmc_sdio_sw_reset,
+ .card_sw_reset = mmc_sdio_card_sw_reset,
};


--
2.30.2