Re: [PATCH 5.4 21/43] selftests/bpf: Add test for bpf_timer overwriting crash

From: gregkh@xxxxxxxxxxxxxxxxxxx
Date: Mon Mar 21 2022 - 08:46:55 EST


On Fri, Mar 18, 2022 at 07:27:07AM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote:
> On Mon, 2022-03-14 at 12:53 +0100, Greg Kroah-Hartman wrote:
> > From: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>
> >
> > [ Upstream commit a7e75016a0753c24d6c995bc02501ae35368e333 ]
> >
> > Add a test that validates that timer value is not overwritten when doing
> > a copy_map_value call in the kernel. Without the prior fix, this test
> > triggers a crash.
> >
> > Signed-off-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>
> > Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> > Link: https://lore.kernel.org/bpf/20220209070324.1093182-3-memxor@xxxxxxxxx
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
>
> Hi, this patch in 5.4.185 breaks bpf selftests build for me:
>
> progs/timer_crash.c:3:10: fatal error: 'vmlinux.h' file not found
> #include <vmlinux.h>
> ^~~~~~~~~~~
>
> Based on quick look, vmlinux.h generation was added to selftests in v5.7,
> so drop this patch in v5.4?

Now reverted, thanks!

greg k-h