Re: [RFT] ufs: qcom: drop custom Android boot parameters

From: Brian Masney
Date: Mon Mar 21 2022 - 09:44:13 EST


On Sun, Mar 20, 2022 at 12:06:16PM +0100, Krzysztof Kozlowski wrote:
> The QCOM UFS driver requires an androidboot.bootdevice command line
> argument matching the UFS device name. If the name is different, it
> refuses to probe. Thise androidboot.bootdevice is provided by
> stock/vendor (from an Android-based device) bootloader.
>
> This does not make sense from Linux point of view. Driver should be
> able to boot regardless of bootloader. Driver should not depend on some
> Android custom environment data.
>
> Cc: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

I encountered that same code a few months ago and thought then that
this code doesn't belong here.

Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>