Re: [PATCH v5 06/22] cachefiles: implement on-demand read

From: JeffleXu
Date: Mon Mar 21 2022 - 10:52:14 EST




On 3/21/22 10:05 PM, David Howells wrote:
> Jeffle Xu <jefflexu@xxxxxxxxxxxxxxxxx> wrote:
>
>> + { "cread", cachefiles_ondemand_cread },
>
> Rather than adding the cread command, would it be better to use an ioctl on
> the anon fd as the /dev/cachefiles write op is serialised?

Sounds reasonable. I will try it in the next version. Thanks.

>
>> + /* Stop enqueuig request when daemon closes anon_fd prematurely. */
>
> "Enqueuing"

Wow.. Maybe I need to update my checkpatch...

--
Thanks,
Jeffle