Re: [PATCH v4 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation

From: Ansuel Smith
Date: Mon Mar 21 2022 - 11:36:03 EST


On Mon, Mar 21, 2022 at 04:33:02PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2022 15:48, Ansuel Smith wrote:
> > Krait-cc qcom driver provide also L2 clocks and require the acpu_l2_aux
> > and the hfpll_l2 clock to be provided. Add these missing clocks to the
> > Documentation.
> >
>
> Thanks. It would be also nice to see here short sentence about expected
> impact, e.g. there are no in-tree DTSes which would be affected, no out
> of tree known users etc.
>
> Because basically with this requirement you change the ABI, so you might
> break some users.
>
> I will leave it to platform maintainers to decide whether it is accepted
> or not.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
>
> Best regards,
> Krzysztof

In the driver I keep support for both and also I tested the changes with
the old wrong implementation. Both works so we shouldn't have any
regression.

--
Ansuel