Re: [PATCH v5 15/18] dt-bindings: clock: Add L2 clocks to qcom,krait-cc Documentation

[Ansuel Smith]

On Mon, Mar 21, 2022 at 04:50:59PM -0500, Rob Herring wrote:
> On Mon, Mar 21, 2022 at 04:38:52PM +0100, Ansuel Smith wrote:
> > Krait-cc qcom driver provide also L2 clocks and require the acpu_l2_aux
> > and the hfpll_l2 clock to be provided. Add these missing clocks to the
> > Documentation. The driver keep support for both old and this new
> > implementation and should prevent any regression by this fixup.
> 
> Depends on what the old driver looks for.
>

The old driver used parent_names with the same name declared now in the
Documentation.

> > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/clock/qcom,krait-cc.yaml     | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> > index e879bfbe67ac..f89b70ab01ae 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,krait-cc.yaml
> > @@ -23,16 +23,20 @@ properties:
> >      items:
> >        - description: phandle to hfpll for CPU0 mux
> >        - description: phandle to hfpll for CPU1 mux
> > +      - description: phandle to hfpll for L2 mux
> >        - description: phandle to CPU0 aux clock
> >        - description: phandle to CPU1 aux clock
> > +      - description: phandle to L2 aux clock
> >        - description: phandle to QSB fixed clk
> 
> Clock indices should not change. New clocks go on the end of the list.
> 

Sad but will change if necessary.

> >  
> >    clock-names:
> >      items:
> >        - const: hfpll0
> >        - const: hfpll1
> > +      - const: hfpll_l2
> >        - const: acpu0_aux
> >        - const: acpu1_aux
> > +      - const: acpu_l2_aux
> >        - const: qsb
> >  
> >    '#clock-cells':
> > @@ -50,10 +54,10 @@ examples:
> >    - |
> >      clock-controller {
> >        compatible = "qcom,krait-cc-v1";
> > -      clocks = <&hfpll0>, <&hfpll1>,
> > -               <&acpu0_aux>, <&acpu1_aux>, <&qsb>;
> > -      clock-names = "hfpll0", "hfpll1",
> > -                    "acpu0_aux", "acpu1_aux", "qsb";
> > +      clocks = <&hfpll0>, <&hfpll1>, <&hfpll_l2>,
> > +               <&acpu0_aux>, <&acpu1_aux>, <&acpu_l2_aux>, <&qsb>;
> > +      clock-names = "hfpll0", "hfpll1", "hfpll_l2",
> > +                    "acpu0_aux", "acpu1_aux", "acpu_l2_aux", "qsb";
> >        #clock-cells = <1>;
> >      };
> >  ...
> > -- 
> > 2.34.1
> > 
> > 

-- 
	Ansuel