Re: [PATCH 3/6] sched: Allow sched_{get,set}attr to change latency_nice of the task

From: Tim Chen
Date: Mon Mar 21 2022 - 20:23:28 EST


On Fri, 2022-03-11 at 17:14 +0100, Vincent Guittot wrote:
>
> +static void __setscheduler_latency(struct task_struct *p,
> + const struct sched_attr *attr)
> +{
> + if (attr->sched_flags & SCHED_FLAG_LATENCY_NICE) {
> + p->latency_prio = NICE_TO_LATENCY(attr->sched_latency_nice);

NICE_TO_LATENCY used here but has defined later in patch 5. This will break
bisect.

> + set_latency_weight(p);
> + }
> }
>
>

Tim