Re: [PATCH RFC 06/11] iommu/sva: Use attach/detach_pasid_dev in SVA interfaces

[Lu Baolu]

On 2022/3/21 20:05, Jason Gunthorpe wrote:
> On Sun, Mar 20, 2022 at 02:40:25PM +0800, Lu Baolu wrote:
>
> > +/**
> > + * iommu_sva_bind_device() - Bind a process address space to a device
> > + * @dev: the device
> > + * @mm: the mm to bind, caller must hold a reference to it
> > + * @drvdata: opaque data pointer to pass to bind callback
> > + *
> > + * Create a bond between device and address space, allowing the device to access
> > + * the mm using the returned PASID. If a bond already exists between @device and
> > + * @mm, it is returned and an additional reference is taken. Caller must call
> > + * iommu_sva_unbind_device() to release each reference.
> > + *
> > + * iommu_dev_enable_feature(dev, IOMMU_DEV_FEAT_SVA) must be called first, to
> > + * initialize the required SVA features.
> > + *
> > + * On error, returns an ERR_PTR value.
> > + */
> > +struct iommu_sva *
> > +iommu_sva_bind_device(struct device *dev, struct mm_struct *mm, void *drvdata)
> The drvdata is never used

Yes. It is cleaned up in Jacob's series.

Best regards,
baolu