Re: [GIT PULL] seccomp update for v5.18-rc1

From: Kees Cook
Date: Tue Mar 22 2022 - 00:54:38 EST




On March 21, 2022 7:45:51 PM PDT, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>On Mon, Mar 21, 2022 at 8:07 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>>
>> Please pull this tiny seccomp update for v5.18-rc1.
>
>Well, that *really* didn't work at all.
>
> In file included from samples/seccomp/dropper.c:29:
> usr/include/linux/ptrace.h:50: warning: "PTRACE_GETREGSET" redefined
> 50 | #define PTRACE_GETREGSET 0x4204
> |
> In file included from samples/seccomp/dropper.c:24:
> /usr/include/sys/ptrace.h:153: note: this is the location of the
>previous definition
> 153 | #define PTRACE_GETREGSET PTRACE_GETREGSET
> |
> [...]
>
>.. and a lot of similar warnings.

Oh, eww. Apologies! That didn't happen for my builders, but yeah, that code is super fragile anyway, so this just confirms my suspicion that the changes weren't useful. I'll drop it from my tree.

--
Kees Cook