Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes

[Krzysztof Kozlowski]

On 22/03/2022 03:32, Dylan Hung wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzk@xxxxxxxxxx]
>> Sent: 2022年3月21日 11:53 PM
>> To: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx>; robh+dt@xxxxxxxxxx;
>> joel@xxxxxxxxx; andrew@xxxxxxxx; andrew@xxxxxxx; hkallweit1@xxxxxxxxx;
>> linux@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx;
>> pabeni@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-aspeed@xxxxxxxxxxxxxxxx;
>> linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx
>> Cc: BMC-SW <BMC-SW@xxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO
>> nodes
>>
>> On 21/03/2022 10:56, Dylan Hung wrote:
>>> Add reset control properties into MDIO nodes.  The 4 MDIO controllers in
>>> AST2600 SOC share one reset control bit SCU50[3].
>>>
>>> Signed-off-by: Dylan Hung <dylan_hung@xxxxxxxxxxxxxx>
>>> Cc: stable@xxxxxxxxxxxxxxx
>>
>> Please describe the bug being fixed. See stable-kernel-rules.
> 
> Thank you for your comment.
> The reset deassertion of the MDIO device was usually done by the bootloader (u-boot).
> However, one of our clients uses proprietary bootloader and doesn't deassert the MDIO
> reset so failed to access the HW in kernel driver.  The reset deassertion is missing in the
> kernel driver since it was created, should I add a BugFix for the first commit of this driver?
> Or would it be better if I remove " Cc: stable@xxxxxxxxxxxxxxx"?

This rather looks like a missing feature, not a bug. Anyway any
description must be in commit message.


Best regards,
Krzysztof