Re: [PATCH v4 1/2] PCI: Rename "pci_dev->untrusted" to "pci_dev->poses_dma_risk"

From: Rafael J. Wysocki
Date: Tue Mar 22 2022 - 07:12:16 EST


On Tue, Mar 22, 2022 at 10:02 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Sat, Mar 19, 2022 at 11:29:05PM -0700, Rajat Jain wrote:
> > Rename the field to make it more clear, that the device can execute DMA
> > attacks on the system, and thus the system may need protection from
> > such attacks from this device.
> >
> > No functional change intended.
> >
> > Signed-off-by: Rajat Jain <rajatja@xxxxxxxxxx>
> > ---
> > v4: Initial version, created based on comments on other patch
>
> What a horrible name. Why not untrusted_dma which captures the
> intent much better?

FWIW, I like this one much better too.