Re: [PATCH 04/11] scsi: libsas: Send SMP commands through the block layer

From: John Garry
Date: Tue Mar 22 2022 - 10:38:09 EST


On 22/03/2022 11:23, Christoph Hellwig wrote:
Wouldn't it make more sense to have a new member in th Scsi_Host_template
that gets called for these request early from ->queue_rq instead of the
new request_queue and custome ops?

I had something like this before, but it also has its disadvantages.

Let me revisit.


FYI, I think reusing the block layer for all these command is a good
idea but the way it is done here seems a bit ugly and not very
maintainable.


Cheers,
John