Re: [PATCH v6 2/6] x86/mce: relocate set{clear}_mce_nospec() functions

From: Jane Chu
Date: Tue Mar 22 2022 - 18:19:44 EST


On 3/22/2022 1:42 AM, Christoph Hellwig wrote:
>> +EXPORT_SYMBOL(set_mce_nospec);
>
> No need for this export at all.

Indeed, my bad, will remove it.

>
>> +
>> +/* Restore full speculative operation to the pfn. */
>> +int clear_mce_nospec(unsigned long pfn)
>> +{
>> + return set_memory_wb((unsigned long) pfn_to_kaddr(pfn), 1);
>> +}
>> +EXPORT_SYMBOL(clear_mce_nospec);
>
> And this should be EXPORT_SYMBOL_GPL.

Yes.

Thanks!
-jane