Re: [PATCH 2/2] Revert "virtio_pci: harden MSI-X interrupts"

From: Marc Zyngier
Date: Wed Mar 23 2022 - 05:05:27 EST


On Wed, 23 Mar 2022 03:15:24 +0000,
Jason Wang <jasowang@xxxxxxxxxx> wrote:
>
> This reverts commit 9e35276a5344f74d4a3600fc4100b3dd251d5c56. Issue
> were reported for the drivers that are using affinity managed IRQ
> where manually toggling IRQ status is not expected. And we forget to
> enable the interrupts in the restore path as well.
>
> In the future, we will rework on the interrupt hardening.
>
> Fixes: 9e35276a5344 ("virtio_pci: harden MSI-X interrupts")
> Reported-by: Marc Zyngier <maz@xxxxxxxxxx>
> Reported-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

For this patch and the INTx one:

Acked-by: Marc Zyngier <maz@xxxxxxxxxx>

Please keep me in the loop when you decide to rework this.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.