Re: [PATCH] PCI: Avoid broken MSI on SB600 USB devices

From: Andy Shevchenko
Date: Wed Mar 23 2022 - 08:24:43 EST


On Wed, Mar 23, 2022 at 1:11 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Wed, Mar 23, 2022 at 10:03:38AM +0200, Andy Shevchenko wrote:
> > On Wed, Mar 23, 2022 at 4:26 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> > > On Mon, Mar 21, 2022 at 01:34:46PM -0500, Bjorn Helgaas wrote:
> > > > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > > >
> > > > Some ATI SB600 USB adapters advertise MSI, but if INTx is disabled by
> > > > setting PCI_COMMAND_INTX_DISABLE,
> >
> > > > MSI doesn't work either.
> >
> > I think this is not correct.
>
> I'd like to make it correct. What would make this better?

MSI with the quirk (not in this patch) is working and has been tested.
That said, the part that I commented on is confusing and states the
opposite. I would change the patch if you ask me how to improve it,

> I was
> trying to say the same as your original commit log:
>
> ATI PCIe-USB adapter advertises MSI, but it doesn't work if INTx is
> disabled.

I'm not a native speaker, maybe I was wrong in formulating that MSI
enabling needs a quirk.

--
With Best Regards,
Andy Shevchenko