Re: [PATCH v2] brcmfmac: Avoid keeping power to SDIO card unless WOWL is used

[Yann Gautier]

On 3/23/22 17:04, Kalle Valo wrote:
> Yann Gautier <yann.gautier@xxxxxxxxxxx> writes:
>
> > On 3/23/22 09:39, Ulf Hansson wrote:
> > > Keeping the power to the SDIO card during system wide suspend, consumes
> > > energy. Especially on battery driven embedded systems, this can be a
> > > problem. Therefore, let's change the behaviour into allowing the SDIO card
> > > to be powered off, unless WOWL is supported and enabled.
> > >
> > > Note that, the downside from this change, is that during system resume the
> > > SDIO card needs to be re-initialized and the FW must be re-programmed. Even
> > > if this may take some time to complete, it should we worth it, rather than
> > > draining the battery.
> > >
> > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> >
> > Thanks for the patch, it is OK, and tested by Christophe (R.).
> > So you can add:
> > Tested-by: Christophe Roullier <christophe.roullier@xxxxxxxxxxx>
> > Acked-by: Yann Gautier <yann.gautier@xxxxxxxxxxx>
>
> Acked-by is used by the driver maintainer, so I assume you mean
> Reviewed-by?
Oops, sorry, yes I meant Reviewed-by.

Best regards,
Yann