Re: [PATCH v1 1/4] spidev: Do not use atomic bit operations when allocating minor

From: Mark Brown
Date: Wed Mar 23 2022 - 15:06:40 EST


On Wed, Mar 23, 2022 at 07:22:52PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 23, 2022 at 04:39:01PM +0000, Mark Brown wrote:

> > There's no *need* but the __ looks suspicious... what's the upside
> > here?

> It's exactly what is written in the commit message

> __*_bit() are non-atomic
> *_bit() are atomic

> Since they are wrapped by mutex, the atomic ones are not needed.

Yes, it's not needed but what meaningful harm does it do?

Attachment: signature.asc
Description: PGP signature