Re: [PATCH] tools/vm/page_owner_sort.c: add switch between culling by stacktrace and txt

From: Andrew Morton
Date: Wed Mar 23 2022 - 15:08:16 EST


On Wed, 23 Mar 2022 10:05:28 +0800 Yinan Zhang <zhangyinan2019@xxxxxxxxxxxxxxxx> wrote:

> >> *(&list[i].txt+offset)) != 0) {
> >>               list2[count++] = list[i];
> >>           } else {
> >>               list2[count-1].num += list[i].num;
> >>
> >
> >
> You are right. Due to timestamp etc, it's almost impossible to
>
> cull by txt. And I did observe some blocks differ in head and same in
>
> stack trace on my linux. The examples I mentioned in patch are
>
> part of them.
>
>
> Besides, --cull has been added in patch:
>
> tools/vm/page_owner_sort.c: support for user-defined culling rules
>

So should I drop this patch?