[allisonhenderson-xfs-work:delayed_attrs_v29_extended 24/31] fs/xfs/libxfs/xfs_parent.c:55:1: warning: no previous prototype for function 'xfs_init_parent_name_rec'

From: kernel test robot
Date: Wed Mar 23 2022 - 18:06:58 EST


tree: https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v29_extended
head: 3106ffcd07787b3bed3ee019d3706c480477ee9c
commit: 7db6d10716e92d4f101981304d1619b77acd569c [24/31] xfs: parent pointer attribute creation
config: x86_64-randconfig-a014 (https://download.01.org/0day-ci/archive/20220324/202203240504.BKIg5zFL-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 902f4708fe1d03b0de7e5315ef875006a6adc319)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/allisonhenderson/xfs_work/commit/7db6d10716e92d4f101981304d1619b77acd569c
git remote add allisonhenderson-xfs-work https://github.com/allisonhenderson/xfs_work.git
git fetch --no-tags allisonhenderson-xfs-work delayed_attrs_v29_extended
git checkout 7db6d10716e92d4f101981304d1619b77acd569c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/xfs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> fs/xfs/libxfs/xfs_parent.c:55:1: warning: no previous prototype for function 'xfs_init_parent_name_rec' [-Wmissing-prototypes]
xfs_init_parent_name_rec(
^
fs/xfs/libxfs/xfs_parent.c:54:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
>> fs/xfs/libxfs/xfs_parent.c:70:1: warning: no previous prototype for function 'xfs_init_parent_name_irec' [-Wmissing-prototypes]
xfs_init_parent_name_irec(
^
fs/xfs/libxfs/xfs_parent.c:69:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void
^
static
2 warnings generated.


vim +/xfs_init_parent_name_rec +55 fs/xfs/libxfs/xfs_parent.c

35
36 /*
37 * Parent pointer attribute handling.
38 *
39 * Because the attribute value is a filename component, it will never be longer
40 * than 255 bytes. This means the attribute will always be a local format
41 * attribute as it is xfs_attr_leaf_entsize_local_max() for v5 filesystems will
42 * always be larger than this (max is 75% of block size).
43 *
44 * Creating a new parent attribute will always create a new attribute - there
45 * should never, ever be an existing attribute in the tree for a new inode.
46 * ENOSPC behavior is problematic - creating the inode without the parent
47 * pointer is effectively a corruption, so we allow parent attribute creation
48 * to dip into the reserve block pool to avoid unexpected ENOSPC errors from
49 * occurring.
50 */
51
52
53 /* Initializes a xfs_parent_name_rec to be stored as an attribute name */
54 void
> 55 xfs_init_parent_name_rec(
56 struct xfs_parent_name_rec *rec,
57 struct xfs_inode *ip,
58 uint32_t p_diroffset)
59 {
60 xfs_ino_t p_ino = ip->i_ino;
61 uint32_t p_gen = VFS_I(ip)->i_generation;
62
63 rec->p_ino = cpu_to_be64(p_ino);
64 rec->p_gen = cpu_to_be32(p_gen);
65 rec->p_diroffset = cpu_to_be32(p_diroffset);
66 }
67
68 /* Initializes a xfs_parent_name_irec from an xfs_parent_name_rec */
69 void
> 70 xfs_init_parent_name_irec(

--
0-DAY CI Kernel Test Service
https://01.org/lkp