Re: [v2 PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent

From: Theodore Ts'o
Date: Wed Mar 23 2022 - 21:48:50 EST


On Thu, Mar 17, 2022 at 04:48:19PM -0700, Yang Shi wrote:
>
> The patch 1 ~ 7 are minor bug fixes, clean up and preparation patches.
> The patch 8 converts ext4 and xfs. We may need convert more filesystems,
> but I'd like to hear some comments before doing that.

Adding a hard-coded call to khugepage_enter_file() in ext4 and xfs,
and potentially, each file system, seems kludgy as all heck. Is there
any reason not to simply call it in the mm code which calls f_op->mmap()?

- Ted