Re: [PATCH V2 1/1] Intel Sky Lake-E host root ports check.

[Jason Gunthorpe]

On Mon, Mar 28, 2022 at 05:35:36PM +0300, Shlomo Pongratz wrote:
> Hi Jason,
> 
> Thank you for your comments I'll fix the spelling mistakes.
> 
> You suggested to remove the port field and to ignore the slot number for root ports,
> and I understand the reasoning, but, from safety reasons, if we know that device 2030
> will always be found on slot 0 and 2032 for example will always be found on slot 2
> wouldn't it be prudent to compare the device number vs the port number,
> unless you believe that the BIOS/ACPI issue will be fixed.

I'm not sure that is guaranteed, it seems like a BIOS choice..

IMHO what we know is that if we see those devices then we are on a
Skylake-E already and we don't really need more checks.

Jason