Re: [PATCH v2 2/2] memory: omap-gpmc: Allow building as a module
From: Krzysztof Kozlowski
Date: Tue Mar 29 2022 - 04:02:48 EST
On 29/03/2022 09:37, Roger Quadros wrote:
> Hi Krzysztof,
>
> On 28/03/2022 16:11, Krzysztof Kozlowski wrote:
>> On 28/03/2022 13:13, Roger Quadros wrote:
>>> Allow OMAP_GPMC to be built as a module.
>>>
>>> Remove redundant of_match_node() call before
>>> of_platform_default_populate() as the latter takes
>>> care of matching with of_default_bus_match_table.
>>
>> Split this part to separate commit, please. It does not look related to
>> making it a module.
>
> Actually it is related. Without that change build fails
> as it cannot find symbol 'of_default_bus_match_table'
Hm, because of missing EXPORT?
Then it is related although to me removal of redundant code still could
be split to separate commit. But I do not insist, if you mention it in
commit msg.
Best regards,
Krzysztof