Re: [PATCH] dt-bindings: net: snps: remove duplicate name

From: Krzysztof Kozlowski
Date: Fri Apr 01 2022 - 03:48:35 EST


On 01/04/2022 05:08, 양동진 wrote:
> snps,dwmac has duplicated name for loongson,ls2k-dwmac and
> loongson,ls7a-dwmac.

Your "From" name seems to be different than Signed-off-by. These should
be the same, so can you fix the commit author to be the same as SoB?

>
> Signed-off-by: Dongjin Yang <dj76.yang@xxxxxxxxxxx>

Fixes: 68277749a013 ("dt-bindings: dwmac: Add bindings for new Loongson
SoC and bridge chip")


> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2d5248f..36c85eb 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -53,20 +53,18 @@ properties:
> - allwinner,sun8i-r40-gmac
> - allwinner,sun8i-v3s-emac
> - allwinner,sun50i-a64-emac
> - - loongson,ls2k-dwmac
> - - loongson,ls7a-dwmac
> - amlogic,meson6-dwmac
> - amlogic,meson8b-dwmac
> - amlogic,meson8m2-dwmac
> - amlogic,meson-gxbb-dwmac
> - amlogic,meson-axg-dwmac
> - - loongson,ls2k-dwmac
> - - loongson,ls7a-dwmac
> - ingenic,jz4775-mac
> - ingenic,x1000-mac
> - ingenic,x1600-mac
> - ingenic,x1830-mac
> - ingenic,x2000-mac
> + - loongson,ls2k-dwmac
> + - loongson,ls7a-dwmac
> - rockchip,px30-gmac
> - rockchip,rk3128-gmac
> - rockchip,rk3228-gmac


Best regards,
Krzysztof