Re: [PATCH][next] iwlwifi: mei: Replace zero-length array with flexible-array member
From: Coelho, Luciano
Date: Fri Apr 01 2022 - 04:10:45 EST
On Mon, 2022-03-28 at 08:48 +0300, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx> writes:
>
> > On Wed, Feb 16, 2022 at 12:35:22PM -0800, Kees Cook wrote:
> > > On Wed, Feb 16, 2022 at 01:50:30PM -0600, Gustavo A. R. Silva wrote:
> > > > There is a regular need in the kernel to provide a way to declare
> > > > having a dynamically sized set of trailing elements in a structure.
> > > > Kernel code should always use “flexible array members”[1] for these
> > > > cases. The older style of one-element or zero-length arrays should
> > > > no longer be used[2].
> > > >
> > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > > > [2]
> > > > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> > > >
> > > > Link: https://github.com/KSPP/linux/issues/78
> > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > >
> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >
> > Hi all,
> >
> > Friendly ping: can someone take this, please?
> >
> > ...I can take this in my -next tree in the meantime.
>
> I'll take this. Luca, ack?
Acked-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
--
Cheers,
Luca.