Re: [PATCH v2 1/4] mtd: spi-nor: Parse BFPT to determine the 4-Byte Address Mode methods
From: Pratyush Yadav
Date: Fri Apr 01 2022 - 06:55:22 EST
On 09/03/22 04:42PM, Tudor Ambarus wrote:
> BFPT[DWORD(16)] defines the methods to enter and exit the 4-Byte Address
> Mode. Parse BFPT to determine the method. Will rename the methods with
> generic names in a further patch, to keep things trackable in this one.
>
> Some regressions may be introduced by this patch, because the
> params->set_4byte_addr_mode method that was set either in
> spi_nor_init_default_params() or later overwritten in default_init() hooks,
> may now be overwritten with a different value based on the BFPT data. If
> that's the case, the fix is to introduce a post_bfpt fixup hook where one
> should fix the wrong BFPT info.
Okay. Let's try to queue this series (and its dependencies) early in the
rc cycle to give some time to catch bugs.
Reviewed-by: Pratyush Yadav <p.yadav@xxxxxx>
--
Regards,
Pratyush Yadav
Texas Instruments Inc.