RE: [PATCH 2/3] iio: ssp_sensors: replace usage of found with dedicated list iterator variable

From: Sa, Nuno
Date: Fri Apr 01 2022 - 08:43:56 EST




> -----Original Message-----
> From: Jakob Koschel <jakobkoschel@xxxxxxxxx>
> Sent: Friday, April 1, 2022 1:07 AM
> To: Jonathan Cameron <jic23@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Dan Carpenter
> <dan.carpenter@xxxxxxxxxx>; Jakob Koschel
> <jakobkoschel@xxxxxxxxx>; linux-iio@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Mike Rapoport <rppt@xxxxxxxxxx>; Brian
> Johannesmeyer <bjohannesmeyer@xxxxxxxxx>; Cristiano Giuffrida
> <c.giuffrida@xxxxx>; Bos, H.J. <h.j.bos@xxxxx>
> Subject: [PATCH 2/3] iio: ssp_sensors: replace usage of found with
> dedicated list iterator variable
>
> [External]
>
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://urldefense.com/v3/__https://lore.kernel.org/all/CAHk-
> =wgRr_D8CB-D9Kg-
> c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@xxxxxxxxxxxxxx/__;!!A3Ni8CS0y
> 2Y!tqcYepOSYys02RcvKD7LiZk3mHwPmSLa_1S0QglWPRZSCoPnXk3ccjY
> _XzsDDA$ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@xxxxxxxxx>
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>