Re: [PATCH 2/2] mm: wrap __find_buddy_pfn() with a necessary buddy page validation.

From: Zi Yan
Date: Fri Apr 01 2022 - 12:49:29 EST

On 1 Apr 2022, at 12:31, Linus Torvalds wrote:

> On Fri, Apr 1, 2022 at 6:58 AM Zi Yan <zi.yan@xxxxxxxx> wrote:
>> +extern bool find_buddy_page_pfn(struct page *page, unsigned int order,
>> + struct page **buddy, unsigned long *buddy_pfn);
> Wouldn't it make more sense to just return the 'struct page *buddy'
> here, instead of the 'bool'?
> So a NULL buddy means the obvious "no buddy found".
> I dislike those "pass return value by reference" in general, and the
> above has _two_ of them.
> We can get rid of at least one very obviously.

Sure. We can get rid of both and calculate buddy_pfn from buddy after
a successful call.

Best Regards,
Yan, Zi

Attachment: signature.asc
Description: OpenPGP digital signature