Re: [PATCH v15 11/12] dmaengine: imx-sdma: add uart rom script

[Russell King (Oracle)]

On Wed, Jul 14, 2021 at 02:41:48AM +0800, Robin Gong wrote:
> For the compatibility of NXP internal legacy kernel before 4.19 which
> is based on uart ram script and upstreaming kernel based on uart rom
> script, add both uart ram/rom script in latest sdma firmware. By default
> uart rom script used.
> Besides, add two multi-fifo scripts for SAI/PDM on i.mx8m/8mm and add
> back qspi script miss for v4(i.mx7d/8m/8mm family, but v3 is for i.mx6).
> 
> rom script:
>         uart_2_mcu_addr
> 	uartsh_2_mcu_addr /* through spba bus */
> am script:
> 	uart_2_mcu_ram_addr
> 	uartsh_2_mcu_ram_addr /* through spba bus */
> 
> Please get latest sdma firmware from the below and put them into the path
> (/lib/firmware/imx/sdma/):
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
> /tree/imx/sdma

Thanks for breaking my platforms when upgrading from 5.13 to 5.16, that
was a really nice experience.

This is _not_ what we do with the Linux kernel. We do not require random
bits of userspace to be upgraded/downgraded in lock-step with the
kernel. There is absolutely no reason for this to happen in this case.

The SDMA firmware is already versioned. You know what version is
present. Randomly renaming stuff in a structure that represents the
contents of firmware like this is just not on.

I know it's taken 9 months to find this, but PLEASE do not ever do this
again, and never think this kind of thing is acceptable. It isn't.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!