Re: [PATCH v12 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller
From: Rob Herring
Date: Fri Apr 01 2022 - 13:53:21 EST
On Fri, Apr 01, 2022 at 02:29:58AM +0000, qinjian[覃健] wrote:
> >
> > On Thu, 31 Mar 2022 16:29:53 +0800, Qin Jian wrote:
> > > Add documentation to describe Sunplus SP7021 interrupt controller bindings.
> > >
> > > Signed-off-by: Qin Jian <qinjian@xxxxxxxxxxx>
> > > ---
> > > Move 'reg' after 'compatible'
> > > ---
> > > .../sunplus,sp7021-intc.yaml | 62 +++++++++++++++++++
> > > MAINTAINERS | 1 +
> > > 2 files changed, 63 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
> > >
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Changes: Move 'reg' after 'compatible'
> I did a modification based on comments from krzysztof.kozlowski@xxxxxxxxxxxxx [1]
>
> [1] https://lore.kernel.org/all/6dbeda18-a11c-609d-7a8f-bf2e6f27aea7@xxxxxxxxxx/
A trivial change like that can keep a tag especially if it came after
the comment (not sure here).
Rob