Re: [PATCH 7/9] nvme-apple: Serialize command issue
From: Sven Peter
Date: Sat Apr 02 2022 - 08:42:28 EST
On Thu, Mar 24, 2022, at 07:16, Christoph Hellwig wrote:
> On Mon, Mar 21, 2022 at 05:50:47PM +0100, Sven Peter wrote:
>> From: Jens Axboe <axboe@xxxxxxxxx>
>> This controller shouldn't need serialization of command issue since
>> the SQ is replaced by a simple array and commands are issued by writing
>> the array index to a MMIO register.
>> Without serialization however sometimes commands are still executed
>> correctly and appear in the CQ but never trigger an interrupt.
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
>> [sven: added our best guess why this needs to be done]
>> Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx>
> This really should go into the previous patch.
Ok, I'll squash it (and the following two patches) into the previous one.