Re: [PATCH v3 9/9] dt-bindings: qcom: qcom,gsbi: convert to dtschema

[Kuldeep Singh]

On Sat, Apr 02, 2022 at 10:38:23PM +0200, Krzysztof Kozlowski wrote:
> On 02/04/2022 22:29, Kuldeep Singh wrote:
> > On Sat, Apr 02, 2022 at 08:40:11PM +0200, Krzysztof Kozlowski wrote:
> >> Convert the Qualcomm General Serial Bus Interface (GSBI) to DT
> >> Schema.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> ---
> >>  .../bindings/soc/qcom/qcom,gsbi.txt           |  87 ------------
> >>  .../bindings/soc/qcom/qcom,gsbi.yaml          | 133 ++++++++++++++++++
> >>  2 files changed, 133 insertions(+), 87 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.txt
> >>  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
> > 
> > Great initiative to convert everything in one go!
> > 
> > [...]
> > 
> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
> >> new file mode 100644
> >> index 000000000000..b97e359f3f90
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,gsbi.yaml
> >> @@ -0,0 +1,133 @@
> >> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/soc/qcom/qcom,gsbi.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Qualcomm General Serial Bus Interface (GSBI)
> >> +
> >> +maintainers:
> >> +  - Andy Gross <agross@xxxxxxxxxx>
> >> +  - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >> +  - Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> >> +
> >> +description:
> >> +  The GSBI controller is modeled as a node with zero or more child nodes, each
> >> +  representing a serial sub-node device that is mux'd as part of the GSBI
> >> +  configuration settings.  The mode setting will govern the input/output mode
> >> +  of the 4 GSBI IOs.
> >> +
> >> +  A GSBI controller node can contain 0 or more child nodes representing serial
> >> +  devices.  These serial devices can be a QCOM UART, I2C controller, spi
> >> +  controller, or some combination of aforementioned devices.
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - qcom,gsbi-v1.0.0
> > 
> > Only 1 entry? const.
> 
> v1.0.0 looks like there could be some more, although they did not reach
> mainline. The GSBI seems to be replaced by different blocks, so maybe
> there will be no new entries here.

Yes, GSBI seems pretty old and only v1 rolled out.
Don't think there are more revisions on the cards. Still can't say so.