Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding

From: Ido Schimmel
Date: Sun Apr 03 2022 - 09:10:43 EST


On Sat, Apr 02, 2022 at 08:15:16AM -0400, Tom Rix wrote:
> The setting of i here
> err_nexthop6_group_get:
> i = nrt6;
> Is redundant, i is already nrt6. So remove
> this statement.
>
> The for loop for the unwinding
> err_rt6_create:
> for (i--; i >= 0; i--) {
> Is equivelent to
> for (; i > 0; i--) {
>
> Two consecutive labels can be reduced to one.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>

For net-next:

Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>