Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR

From: Thomas Gleixner
Date: Sun Apr 03 2022 - 15:58:22 EST


On Sun, Apr 03 2022 at 20:50, Borislav Petkov wrote:
> On Sun, Apr 03, 2022 at 03:16:20PM +0200, Borislav Petkov wrote:
>> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
>> index 9ccc2ea0ea00..4acc7959be6e 100644
>> --- a/arch/x86/kernel/cpu/mce/amd.c
>> +++ b/arch/x86/kernel/cpu/mce/amd.c
>> @@ -723,7 +723,7 @@ bool amd_mce_is_memory_error(struct mce *m)
>> }
>>
>> /* Extract [55:<lsb>] where lsb is the LS-*valid* bit of the address bits. */
>> -void smca_extract_err_addr(struct mce *m)
>> +void __always_inline smca_extract_err_addr(struct mce *m)
>
> Ok, flip those - the pedantic bot is not happy:
>
>>> arch/x86/kernel/cpu/mce/amd.c:726:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
> 726 | void __always_inline smca_extract_err_addr(struct mce *m)
> | ^~~~
>
> Needs to be
>
> __always_inline void
>
> whateva...

How is __always_inline supposed to work across compilation units w/o
LTO? The callsite is in core.c ...

Thanks,

tglx